Skip to content

Update the latest vscode-html-languageserver #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 17, 2020
Merged

Update the latest vscode-html-languageserver #3

merged 12 commits into from
Mar 17, 2020

Conversation

@jfcherng
Copy link
Collaborator

@jfcherng jfcherng commented Mar 17, 2020 •
edited
Loading

The binary from vscode-html-languageserver-bin is quite old. There seems to be lots of features not working with the outdated server.

We have to compile it from the source by ourselves.

We also have to add some initializationOptions and settings to make it work better.

This PR also changes the overall code/directory structure to be the same with LSP-eslint.

Now, it supports
2020-03-17_20-35-37
None of above features are available before this PR.

@jfcherng
Update the latest vscode-html-languageserver
47c1dd0 
We have to compile it from the source by ourselves.

- https://github.com/jfcherng/vscode-html-languageserver-bin/tree/sublime-text
- mattn/vim-lsp-settings#48

We also have to add some initializationOptions and settings to make it
work better.

Signed-off-by: Jack Cherng <[email protected]>
@rchl rchl requested review from predragnikolic and rchl March 17, 2020 13:12
@jfcherng jfcherng mentioned this pull request Mar 17, 2020
Merged
rchl
rchl requested changes Mar 17, 2020
View reviewed changes
rchl
rchl reviewed Mar 17, 2020
View reviewed changes
@rchl
Copy link
Member

rchl commented Mar 17, 2020

We should also commit vscode-html/package-lock.json as otherwise the dependencies can get updated and break something. We should be in control of when we want to update dependencies.

rchl
rchl requested changes Mar 17, 2020
View reviewed changes
rchl
rchl reviewed Mar 17, 2020
View reviewed changes
@jfcherng
Copy link
Collaborator Author

jfcherng commented Mar 17, 2020

We should also commit vscode-html/package-lock.json as otherwise the dependencies can get updated and break something. We should be in control of when we want to update dependencies.

Done.

jfcherng added 2 commits March 17, 2020 22:33
@jfcherng
Coding style fixes
261d7a7 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
nits
9afa659 
Signed-off-by: Jack Cherng <[email protected]>
rchl
rchl approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but lets wait for lsp_utils before merging this.

predragnikolic
predragnikolic reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@predragnikolic predragnikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jfcherng thank you for this :)
I tried using Find Symbol References and Go Ro Symbol Definition, but that doesn't do anything. Am I missing something?

@jfcherng
Copy link
Collaborator Author

jfcherng commented Mar 17, 2020 •
edited
Loading

I tried using Find Symbol References and Go Ro Symbol Definition, but that doesn't do anything. Am I missing something?

I guess it only usable in js/css context. Since reference and definition are hmm... not having a clear meaning in HTML? Rename Symbol does work on HTML tag name (like h1 to h2) but not in js/css though... Feel quite limited...

image

@predragnikolic predragnikolic merged commit f0e2161 into sublimelsp:master Mar 17, 2020
@predragnikolic
Copy link
Member

predragnikolic commented Mar 17, 2020

BTW, lsp_utils is merged to Package Control :)

@jfcherng jfcherng deleted the update-vscode-server branch March 17, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchl rchl rchl approved these changes

@predragnikolic predragnikolic predragnikolic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfcherng @rchl @predragnikolic